Fix Compatibility Issue with Object Property Check Update use-draw.ts #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses a compatibility issue in the paths object by replacing the non-standard Object.hasOwn() method with the safer and more widely supported Object.prototype.hasOwnProperty.call(). This change ensures better cross-browser and cross-environment compatibility for property existence checks.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gregnazario
reviewed
Dec 10, 2024
| if (!Object.hasOwn(paths, defaultLocale)) { | ||
| if (!Object.prototype.hasOwnProperty.call(paths, defaultLocale)) { |
There was a problem hiding this comment.
hmm interesting, how many browsers wouldn't support hasOwn
This answer on stack overflow points that this is preferred https://stackoverflow.com/questions/69561596/object-hasown-vs-object-prototype-hasownproperty
Seems like most modern browsers support it?
|
This issue is stale because it has been open 45 days with no activity. Remove the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed an issue in the paths object where
Object.hasOwn(paths, defaultLocale)was used to check for the presence of thedefaultLocalekey. WhileObject.hasOwn()works in some environments, it is not a standard method in JavaScript and may cause compatibility issues across different platforms or environments.Issue
The code incorrectly used
Object.hasOwn(paths, defaultLocale), which is not part of the standard JavaScript API. The correct and safer method to check for the presence of a key in an object isObject.prototype.hasOwnProperty.call(paths, defaultLocale).Fix
Replaced
Object.hasOwn(paths, defaultLocale)withObject.prototype.hasOwnProperty.call(paths, defaultLocale)to ensure compatibility and to follow best practices for property checks in JavaScript.Importance
This change ensures better cross-environment compatibility, as
Object.hasOwn()is not universally supported. Using the standardhasOwnProperty.call()method is a safer and more reliable way to check for the presence of a property in an object. This fix improves code robustness and reduces the risk of runtime errors in different JavaScript environments.Checklist
pnpm spellcheck?pnpm fmt?pnpm lint?